Implementation of Git repository support for the Malicious Packages repository. #1047
+764
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Caleb Brown <[email protected]>
Signed-off-by: Caleb Brown <[email protected]>
Signed-off-by: Caleb Brown <[email protected]>
Signed-off-by: Caleb Brown <[email protected]>
Signed-off-by: Caleb Brown <[email protected]>
Signed-off-by: Caleb Brown <[email protected]>
Signed-off-by: Caleb Brown <[email protected]>
Signed-off-by: Caleb Brown <[email protected]>
This allows doc changes to be iterated on differently. Signed-off-by: Caleb Brown <[email protected]>
Also adds tests to ensure the new validation rules work as expected. Signed-off-by: Caleb Brown <[email protected]>
distractible
approved these changes
Nov 4, 2025
| // There is a direct match, so return the handler immediately. | ||
| return handler | ||
| } | ||
| for suffix, handler := range gitHosts { |
Collaborator
There was a problem hiding this comment.
I guess iteration order will be random, if we ever have two suffix patterns that would match.
Contributor
Author
There was a problem hiding this comment.
That is true. I have added a comment above to make this clearer.
For now I am okay with this.
internal/gitname/hosts.go
Outdated
| return checkPathParts(path, 2) | ||
| } | ||
|
|
||
| func checkPathParts(path string, partCount int) bool { |
Collaborator
There was a problem hiding this comment.
comment I guess - maybe count instead of partCount too
internal/gitname/hosts.go
Outdated
| return true | ||
| } | ||
|
|
||
| // canonLowerOrg lowercases the first path component in the supplied path. |
internal/report/validate.go
Outdated
|
|
||
| // validateGitCommtID ensures that candidate is a validly formatted git commit | ||
| // ID hash. Git commit IDs are a hex-encoded SHA1 or SHA256 hash. | ||
| func validateGitCommtID(candidate string, allowZero bool) error { |
Collaborator
There was a problem hiding this comment.
validateGitCommitID throughout
Signed-off-by: Caleb Brown <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1034 for the design doc.